[Bug 953701] Review Request: python-webm - Python wrapper to WebM libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953701

--- Comment #2 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> ---
(In reply to comment #1)
> [?]: Final provides and requires are sane (see attachments).
> ===========================
> > #use the right library
> > sed -i 's/libwebp\.so\.0/libwebp\.so\.4/' webm/__init__.py
> 
> Depending on a specific soversion is fine. How does this handle the case when
> libwebp soversion is bumped?

If there's a soname bump I'd really want to retest the package to make sure it
still works properly and rebuild.  Even though ctypes-based libraries don't
break obviously like regularly linked libraries do there's still plenty of room
for unobvious breakage, and ctypes libraries are notorious for that.  I'd
rather get the broken dependency e-mail and be forced to test and rebuild than
let it potentially break silently.

I macroified the soname just to make bumping it easier in the future, though.

> > $ rpm -qRp python-webm-0.2.2-1.fc18.noarch.rpm
> > libwebp
> > ...
> 
> This seems incomplete, since the package depends explicitly on libwebp.so.4
> ---------------------------

You're right.  Unfortuntately, there's no way to depend on the soname-based
virtual provides from a noarch package properly, so this package ended up
becoming arched as a result.  It's probably for the best, because even though
it's a pure Python package this will make it work in a multilib world more
nicely.

--

Spec: http://patches.fedorapeople.org/xpra/python-webm.spec
SRPM: http://patches.fedorapeople.org/xpra/python-webm-0.2.2-1.fc19.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5336906

* Mon May 06 2013 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> - 0.2.2-2
- fix up dependency on libwebp (package became arched as a result)
- fix License tag
- explicitly list python version in BuildRequires
- be more verbose when running tests

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MmaePgfnB9&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]