Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 --- Comment #10 from Alex G. <mr.nuke.me@xxxxxxxxx> --- (In reply to comment #9) > > [!]: Fully versioned dependency in subpackages, if present. > > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > > libint2-devel > > Added the %{?_isa}. > Where is the new .spec ? > > [!]: Large documentation must go in a -doc subpackage. > > Note: Documentation size is 911360 bytes in 2 files. > > I'm following the same rationale as in libint. This is a highly specialized > package, and is only going to be installed by developers, for which the > documentation is very much important, since the library is pretty much > useless without it (requires many pages worth of initializing procedures). > > (Note that the compiled library itself is 201MB!) > My rationale is that some developers (such as myself) like to install a minimal -devel package and read the documentation online. Now, a pdf file of < 1MB is not a big issue. It's your choice. This point is [x]. > (In reply to comment #8) > > The correct address is: > > 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA > > Please have upstream update their LICENSE file. > > I'll ask upstream to perform the update, and possibly add a proper COPYING > file as well. > Cool. Thanks. > > If you plan to also package for EPEL5, I recommend you only keep the above in > > the EPEL5 branch, and remove them from EPEL6 and Fedora branches. > > There's no sense in multiplying the workload without any added benefit. The > obsoleted stuff doesn't hurt anything. > Ok. I accept your answer. > > Can the documentation use parallel make? > > Not really - it's about running LaTeX on a single file, and doxygen. > Then it's not a problem. > > > %{_libdir}/libint*.so.* > > Please consider versioning here: > > %{_libdir}/libint*.so.1* > > This makes it very easy to catch soname version bumps, and is much safer than > > undiscriminately accepting any library the build spits out. > > Well, in the case of libint sonames don't have much use anyway, since in my > experience one can break the ABI compatibility just by changing the > configure flags. OK. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mP5lo2maMN&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review