Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959734 --- Comment #4 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- While the nexus-osciprime firmware falls under the binary firmware exception so it's okay to use the prebuilt binary, in order to be complaint with the GPLv2 you still need to ship the source code to it in the SRPM. You should also set the license tag to GPLv2(+). Does upstream plan to add more firmware to this package in the future? It seems silly to use -nonfree and -free subpackages when each only contains one kind of firmware. It seems to make more sense just to name the package after the type of firmware included. Rpmlint ------- Checking: sigrok-firmware-free-0.1.0-1.20130426git83e0802.fc20.noarch.rpm sigrok-firmware-filesystem-0.1.0-1.20130426git83e0802.fc20.noarch.rpm sigrok-firmware-0.1.0-1.20130426git83e0802.fc20.src.rpm sigrok-firmware-nonfree-0.1.0-1.20130426git83e0802.fc20.noarch.rpm sigrok-firmware-free.noarch: E: description-line-too-long C The sigrok-firmware-free package contains firmwares which are available under free Please wrap at 80 characters. sigrok-firmware-free.noarch: W: invalid-license Redistributable Please use an appropriate license tag for the GPL here. sigrok-firmware-filesystem.noarch: W: summary-not-capitalized C sigrok-firmware directory structure Something like "Directory structure for the Sigrok firmware" would shut this up. sigrok-firmware-filesystem.noarch: W: invalid-license Redistributable Please use a valid license specifier (since this just contains a single directory something like Public Domain would probably be most accurate). sigrok-firmware.src: W: spelling-error %description -l en_US libsigrok False positive, library name, sigrok-firmware.src: E: description-line-too-long C sigrok-firmware only contains firmware files which have an explicit permission/license Please wrap at 80 characters. sigrok-firmware.src: W: invalid-license Redistributable Please use the union of the licenses for the SRPM, just to make things clear. e.g. GPLv2 and Redistributable, no modification permitted sigrok-firmware.src:16: W: macro-in-comment %{name} sigrok-firmware.src:16: W: macro-in-comment %{version} sigrok-firmware.src:16: W: macro-in-comment %{name} sigrok-firmware.src:16: W: macro-in-comment %{version} sigrok-firmware.src:16: W: macro-in-comment %{checkout} Please escape macros used in comments. (e.g. "%%{name}") sigrok-firmware.src: W: invalid-url Source0: sigrok-firmware-0.1.0-20130426git83e0802.tar.gz OK, instructions for generating in the comments. sigrok-firmware-nonfree.noarch: E: description-line-too-long C The sigrok-firmware-nonfree package contains firmwares available under non-free licenses Again, please wrap at 80 characters. 4 packages and 0 specfiles checked; 3 errors, 11 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iBzMMakUST&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review