Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: HippoDraw - Interactive and Python scriptable data analysis application https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208034 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-03-07 12:06 EST ------- Well, for 1.19.3-1: * rpmlint - rpmlint is not silent. Among them what cannot be ignored are: ------------------------------------------------- W: HippoDraw incoherent-version-in-changelog 1.19.2-1 1.19.3-1.fc7 W: HippoDraw undefined-non-weak-symbol /usr/lib/libaxiswidget.so.0.0.0 _ZN9hippodraw5Range6setLowEd W: HippoDraw undefined-non-weak-symbol /usr/lib/libaxiswidget.so.0.0.0 _ZNK9hippodraw5Range3lowEv W: HippoDraw undefined-non-weak-symbol /usr/lib/libaxiswidget.so.0.0.0 _ZNK9hippodraw5Range3posEv W: HippoDraw undefined-non-weak-symbol /usr/lib/libaxiswidget.so.0.0.0 _ZN9hippodraw5Range8setRangeEddd W: HippoDraw undefined-non-weak-symbol /usr/lib/libaxiswidget.so.0.0.0 _ZN9hippodraw5Range7setHighEd W: HippoDraw undefined-non-weak-symbol /usr/lib/libaxiswidget.so.0.0.0 _ZNK9hippodraw5Range4highEv ------------------------------------------------- * Please fix the version in %changelog * Well, as this package provides -devel package, the existence of undefined non-weak symbol in a library cannot be ignored, because the linkage of this library fails because of these symbols. * Documentation - Usually documentation should be installd under %{_datadir}/%{name}-%{version}/ * Desktop file ------------------------------------------------- Categories=Application;Science & Math; ------------------------------------------------- - Category "Application" is deprecated and should be removed. - Category "Science & Math" is invalid. * Python directory - Check if using python_sitelib is correct. Usually arch-dependent python items (such as python library) should be installed under python_sitearch (check : http://fedoraproject.org/wiki/Packaging/Python ) * Requires A. for -devel package: - Check the missing dependencies. For example, /usr/include/HippoDraw/qt/CanvasWindow.h contains the line: ------------------------------------------------- #include <qcanvas.h> ------------------------------------------------- This means that -devel package should need "Requires: qt-devel". Also check if other dependencies may exist. B. for main package - Explicit note of dependency for library rpm (i.e. "Requires: cfitsio") is not needed. The dependencies for libraries (i.e. libcfitsio.so.0) automatically pulls this dependency. - Check if "tetex-latex tetex-dvips netpbm-progs" arereally required. These are truely used to rebuild this package, however, are they required for runtime? C. for -python package: - Check the missing dependencies. For example, /usr/share/HippoDraw/examples/fft.py contains the line: -------------------------------------------------- import numarray -------------------------------------------------- This means that -python package should need "Requires: python-numarray". Also check if other dependencies may exist. ? By the way, /usr/lib/python2.5/site-packages/HippoDraw/FitsAxis.py contains: -------------------------------------------------- import numarray, pyfits -------------------------------------------------- Then what provides pyfits module? * Directory/file ownership - Duplicate files several files are installed in more than one package. ------------------------------------------------- [tasaka1@localhost i386]$ rpm -qlp HippoDraw-*rpm | sort | uniq -d /usr/share/doc/HippoDraw/DISCLAIMER.rtf /usr/share/doc/HippoDraw/LICENSE /usr/share/doc/HippoDraw/html/hippo.html ------------------------------------------------- - For -doc package Currently -doc package does not require main package. Well, if only -doc package is installed without main package, the directories ------------------------------------------------- /usr/share/doc/HippoDraw /usr/share/doc/HippoDraw/html ------------------------------------------------- are not owned by any package, so this is not right. * Timestamps - Well, this package contains many - text files such as header files - image files and so on, and keeping timestamps on these files are recommended. Usually -------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" -------------------------------------------------- will work. * Build log - Well, what are the many lines like following? -------------------------------------------------- sh: dot: command not found Problems running dot. Check your installation! -------------------------------------------------- Are these okay? - And ghostscript is perhaps needed for BuildRequires -------------------------------------------------- Document Class: article 2004/02/16 v1.4f Standard LaTeX document class (/usr/share/texmf/tex/latex/base/size10.clo)) (/usr/share/texmf/tex/latex/graphics/epsfig.sty (/usr/share/texmf/tex/latex/graphics/graphicx.sty (/usr/share/texmf/tex/latex/graphics/keyval.sty) (/usr/share/texmf/tex/latex/graphics/graphics.sty (/usr/share/texmf/tex/latex/graphics/trig.sty) (/usr/share/texmf/tex/latex/graphics/graphics.cfg) (/usr/share/texmf/tex/latex/graphics/dvips.def)))) No file _formulas.aux. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] (./_formulas.aux) ) Output written on _formulas.dvi (26 pages, 4328 bytes). Transcript written on _formulas.log. sh: gs: command not found Problem running ghostscript gs -q -g429x64 -r384x384x -sDEVICE=ppmraw -sOutputFile=_form0.pnm -dNOPAUSE -dBATCH -- _form0.ps. Check your installation! -------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review