Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921847 --- Comment #8 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- (In reply to comment #7) > - License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. No licenses found. > Please check the source files for licenses manually. > See: > http://fedoraproject.org/wiki/Packaging/ > LicensingGuidelines#ValidLicenseShortNames LICENSE file contains BSD. > [?]: Package contains no bundled libraries without FPC exception. Not sure why this has a question mark; no libraries are bundled. > [x]: Changelog in prescribed format. > [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. > Note: rm -rf %{buildroot} present but not required > > Consider removing rm -rf %{buildroot} I dropped the EL5isms from this package. > [?]: Package requires other packages for directories it uses. Not sure why this has a question mark; the only directory needed is %{nodejs_sitelib}, which is owned by nodejs, Requires on which are automatically added by the nodejs dep generator. > [!]: Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > Note: %clean present but not required I dropped the EL5isms from this package, as indicated above. > [x]: If the source package does not include license text(s) as a separate > file > from upstream, the packager SHOULD query upstream to include it. > [x]: Final provides and requires are sane (see attachments). > [?]: Package functions as described. It does. ;-) > [?]: Latest version is packaged. % npm view ycssmin version npm http GET https://registry.npmjs.org/ycssmin npm http 200 https://registry.npmjs.org/ycssmin 1.0.1 > Add shebang or remove executable bits Fixed. -- Spec: http://patches.fedorapeople.org/node-misc/ycssmin.spec SRPM: http://patches.fedorapeople.org/node-misc/ycssmin-1.0.1-3.fc19.src.rpm * Mon May 06 2013 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> - 1.0.1-3 - improve description - drop spurious executable permissions - drop EL5isms -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JGJI5pqZHz&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review