Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959720 --- Comment #2 from Alex G. <mr.nuke.me@xxxxxxxxx> --- > It's rather odd that every single source file states that the license is > GPLv2+, but the readme states that > > "PulseView is licensed under the terms of the GNU General Public License > (GPL), version 3 or later. > > While some individual source code files are licensed under the GPLv2+, and > some files are licensed under the GPLv3+, this doesn't change the fact that > the program as a whole is licensed under the terms of the GPLv3+ (e.g. also > due to the fact that it links against GPLv3+ libraries)." > > This is clearly in error. Maybe contact upstream and ask them to change this? > This is actually correct. PulseView links to libsigrok and libsigrokdecode which are both GPLv3+. While the PulseView sources are GPLv2+, when it is linked and distributed as a binary, it becomes GPLv3+. It's what the README is saying. > > [!]: Package consistently uses macros (instead of hard-coded directory > names). > > - You are mixing %{name} and pulseview in %files. Choose one and stick with > it. > Thanks. fixed > > Final comments: > > > I think you're abusing wildcards for no reason in > %{_mandir}/man*/* > Since this is only a single file, please replace this by > %{_mandir}/man1/pulseview.1* > Thanks. fixed. > > You're also missing a comment for SOURCE1: what's it for, where is it from > and has it been sent upstream? A desktop file is required for GUI applications: https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files > If the package doesn't already include and install its own .desktop file, you > need to make your own. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6XRLeLg3H5&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review