Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958881 Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs? --- Comment #6 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> --- (In reply to comment #5) > 1) I don't think you need to add any comments for desktop file installation > like you added > "# Upstream doesn't validate their desktop files" > This is a standard packaging policy to install desktop files. I know, I left it mostly for me, as a reminder that I should try to find if there's a way I can do that upstream, so other distros also benefit. :) > 2) Autotools stuff just installs generated desktop file into path > /usr/share/applications. I have not seen yet any project using either > desktop-file-validate or some way to validate desktop file before getting > installed. Yeah, me neither. :-/ I just thought I'd ask. > 3) New updated SRPM looks good. > > One more thing I want to suggest is to use following way for make install > line as this will preserve the timestamps of files from upstream tarball. > > make install DESTDIR=%{buildroot} INSTALL="install -p" Oh, forgot about that one too. I'll fix it when I import the package! > APPROVED this package. Thanks a lot for the review Parag, this one and the python3-cangjie one. :) New Package SCM Request ======================= Package Name: ibus-cangjie Short Description: IBus engine to input Cangjie and Quick Owners: bochecha Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bhCZyJztU3&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review