Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960047 --- Comment #3 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Execute test suite - It seems that there is available test suite in upstream repository. Could you please execute it? You can find small how-to here [1] * License - There is no separate LICENSE file. Could you please ask upstream to include one [2]? - Since there is no separate LICENSE file, I would suggest to move the README.rdoc, which contains some licensing information, into the main package. - Could you please ask upstream about clarification of their license? The "Released under the same license as Ruby" is a bit vague, since Ruby itself changed license from "Ruby or GPL+" (used until Ruby 1.9.2) to "Ruby or BSD" (for Ruby 1.9.3 and newer). - Please note that the license should contain "or" instead of "and" in any case. * Raketasks are probably not needed - Could you please ensure, that the migrate.rake file is useful for the gem? I would say, that it has its purpose, when the gem would be used as Rails plugin, but that is not our case. [1] https://fedoraproject.org/wiki/Packaging:Ruby#Test_suites_not_included_in_the_package [2] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X5jBhoDdhy&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review