Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jline-0.9.9-1jpp - Java library for reading and editing user input in console applications https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227071 mwringe@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|mwringe@xxxxxxxxxx |tbento@xxxxxxxxxx ------- Additional Comments From mwringe@xxxxxxxxxx 2007-03-07 11:19 EST ------- (In reply to comment #2) > Just a couple things: > > - Should the post and postun sections for javadoc be removed? They have been removed, I didn't remove them before since we have hard coded the srpm to use ant instead of maven (and the ant build doesn't have javadocs) > - Some lines have more than 80 characters. I believe only the description has to be less than 80 characters per line, which it is. If this is not the case let me know. > - Should gcj support be added? I added gcj support. > - I think group should be changed to Development/Libraries. Groups are ignored by fedora so they shouldn't matter. But since this causes an issue with rpmlint, I have changed it. https://mwringe.108.redhat.com/files/documents/175/265/jline.spec https://mwringe.108.redhat.com/files/documents/175/266/jline-0.9.9-1jpp.1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review