Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959747 --- Comment #2 from Eugene A. Pivnev <ti.eugene@xxxxxxxxx> --- Initial pre-review: * rm -rf $RPM_BUILD_ROOT is not nesessary: http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean * %defattr(-,root,root,-) is not nesessary: http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions * to avoid double doc folders and other conflicts (/usr/share/doc/jimtcl/ is in both packages - as in main as in -devel) - you can use additional docs right from sources: ... %make_install +rm -rf %{buildroot}/%{_datadir}/doc/%{name} ... -%doc LICENSE AUTHORS README -%doc %{_docdir}/%{name}/Tcl.html +%doc LICENSE AUTHORS README Tcl.html ... -%doc DEVELOPING -%doc %{_docdir}/%{name}/README.extensions +%doc DEVELOPING README.extensions * If you ship README.extensions and switch all extensions On - to add README.<other_extentions> will be usual * STYLE file (-devel) will be usual too * You must fix git snapshot that you use. Best way - to use git tag in github mirror: https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github * If you have "so" patch - welcome * Adding Koji builds will be welcoming too -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=f3XwBiac46&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review