Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #55 from Eugene A. Pivnev <ti.eugene@xxxxxxxxx> --- (In reply to comment #51) > * all of your sub-packages need to Require razorqt-data such that the > license is always installed. Fixed. Note #1: instead of adding -data to Requires I added licenses to libqxtdg and -libs. According to dependency graph (http://tieugene.fedorapeople.org/rpms/razorqt/razorqt.svg or http://tieugene.fedorapeople.org/rpms/razorqt/razorqt.dot) any other subpackage requires one/some/all of them. Note #2: -xdg is not part of razorqt - it is just fixed version of xdg-utils for EL6. > * could clean up your change log and commetns. Use %% where appropriate and > you've got some double hyphenating Fixed. > I'm used to seeing the %description right after the %package declaration but > thats a matter of style. I'd like to choose something one - "section > subpackage" or "package > section" order. In 2nd case I'm to put package > %description > %files (together). I prefere _strict_ "section > subpackage" order, sorry. > Fix the license requires and I'll approve. Good job Whew... Thank you very much. Koji builds (dist-6E-epel, f17..rawhide): http://koji.fedoraproject.org/koji/taskinfo?taskID=5332318 http://koji.fedoraproject.org/koji/taskinfo?taskID=5332332 http://koji.fedoraproject.org/koji/taskinfo?taskID=5332337 http://koji.fedoraproject.org/koji/taskinfo?taskID=5332360 http://koji.fedoraproject.org/koji/taskinfo?taskID=5332365 Spec URL: http://tieugene.fedorapeople.org/rpms/razorqt/razorqt.spec SRPM URL: http://tieugene.fedorapeople.org/rpms/razorqt/razorqt-0.5.2-7.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7Kp5mEcpfW&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review
