[Bug 957693] Review Request: gfal2-python - Python bindings for gfal 2.0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957693

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m

--- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
rpmlint output (based on the f20 koji build):

$ rpmlint -i -v *
gfal2-python.src: I: checking
gfal2-python.src: W: spelling-error Summary(en_US) gfal -> gal, goal, fall
The value of this tag appears to be misspelled. Please double-check.

gfal2-python.src: W: spelling-error %description -l en_US gfal -> gal, goal,
fall
The value of this tag appears to be misspelled. Please double-check.

gfal2-python.src: I: checking-url
https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds)
gfal2-python.src: I: checking-url
http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-python/gfal2-python-1.2.0.tar.gz
(timeout 10 seconds)
gfal2-python.i686: I: checking
gfal2-python.i686: W: spelling-error Summary(en_US) gfal -> gal, goal, fall
The value of this tag appears to be misspelled. Please double-check.

gfal2-python.i686: W: spelling-error %description -l en_US gfal -> gal, goal,
fall
The value of this tag appears to be misspelled. Please double-check.

gfal2-python.i686: I: checking-url
https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds)
gfal2-python.i686: W: private-shared-object-provides
/usr/lib/python2.7/site-packages/gfal2.so gfal2.so
A shared object soname provides is provided by a file in a path from which
other packages should not directly load shared objects from.  Such shared
objects should thus not be depended on and they should not result in provides
in the containing package.  Get rid of the provides if appropriate, for
example by filtering it out during build.  Note that in some cases this may
require disabling rpmbuild's internal dependency generator.

gfal2-python.x86_64: I: checking
gfal2-python.x86_64: W: spelling-error Summary(en_US) gfal -> gal, goal, fall
The value of this tag appears to be misspelled. Please double-check.

gfal2-python.x86_64: W: spelling-error %description -l en_US gfal -> gal, goal,
fall
The value of this tag appears to be misspelled. Please double-check.

gfal2-python.x86_64: I: checking-url
https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds)
gfal2-python.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/gfal2.so gfal2.so()(64bit)
A shared object soname provides is provided by a file in a path from which
other packages should not directly load shared objects from.  Such shared
objects should thus not be depended on and they should not result in provides
in the containing package.  Get rid of the provides if appropriate, for
example by filtering it out during build.  Note that in some cases this may
require disabling rpmbuild's internal dependency generator.

gfal2-python-debuginfo.x86_64: I: checking
gfal2-python-debuginfo.x86_64: I: checking-url
https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds)
gfal2-python-doc.i686: I: checking
gfal2-python-doc.i686: I: checking-url
https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds)
gfal2-python-doc.x86_64: I: checking
gfal2-python-doc.x86_64: I: checking-url
https://svnweb.cern.ch/trac/lcgutil/wiki/gfal2-python (timeout 10 seconds)
gfal2-python.spec: I: checking-url
http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/gfal2-python/gfal2-python-1.2.0.tar.gz
(timeout 10 seconds)
6 packages and 1 specfiles checked; 0 errors, 8 warnings.



W: private-shared-object-provides /usr/lib/python2.7/site-packages/gfal2.so
gfal2.so
Don't know what it means and how this could be fixed. Any explanation is
welcome.

Please use python2-devel instead of python-devel:
https://fedoraproject.org/wiki/Packaging:Python#BuildRequires

glib2-devel is redundant, it is needed by gfal2-devel anyway. Please drop it
from BR.



$ rpm -qpR gfal2-python-1.2.0-0.fc20.i686.rpm
boost(x86-32)
libboost_python-mt.so.1.53.0
libc.so.6
libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.4)
libgcc_s.so.1
libgcc_s.so.1(GCC_3.0)
libgfal2.so.2
libgfal_transfer.so.2
libglib-2.0.so.0
libgthread-2.0.so.0
libm.so.6
libpython2.7.so.1.0
libstdc++.so.6
libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(GLIBCXX_3.4)
libstdc++.so.6(GLIBCXX_3.4.11)
libstdc++.so.6(GLIBCXX_3.4.9)
python(abi) = 2.7
python(x86-32)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rtld(GNU_HASH)
rpmlib(PayloadIsXz) <= 5.2-1

Obviously your explicit runtime requirements are unneeded. Both Boost and
Python are picked up automatically.

The -doc subpackage doesn't contain any arch specific files, please tag it as
"BuildArch: noarch". Moreover, the %{?_isa} tag there is obsolete then.

The %changelog section is somewhat overloaded. Put any changes there regarding
the package itself, not the underlying upstream software.

Once the package is ready for importing it to the Git repo, make sure you
remove all the EPEL5-specific parts from the non-EPEL5 spec files (%defattr,
%clean section, initial cleaning of buildroot in %install and the BuildRoot:
tag).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8BrzeG1KRx&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]