Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957573 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx --- Comment #19 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- Sorry to get here a bit late. But I really thinkg this package shouldn't have been approved. 1/ a lot of file are docs. Better solution to move docs in docs, is to change "role" in the package.xml, this allow to keep pear metadata consistent (check "pear list aws/sdk") So, for example: sed -e '/_samples/s/role="php"/role="doc"/' \ -e '/_docs/s/role="php"/role="doc"/' \ -e '/_compatibility_test/s/role="php"/role="doc"/' \ -e '/_sql/s/role="php"/role="doc"/' \ -e '/LICENSE/s/role="php"/role="doc"/' \ -e '/README/s/role="php"/role="doc"/' \ package.xml >%{pear_name}-%{version}/%{name}.xml Of course, this is an upstream bug which should be reported and fixed upstream. 2/ bundled libraries - AWSSDKforPHP/lib/cachecore - AWSSDKforPHP/lib/dom - AWSSDKforPHP/lib/yaml - AWSSDKforPHP/lib/requestcore Guidelines prohibit this. https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries At least symfony/yaml is available in pear channel so upstream so use a pear dependency. And this will solves the Licensing issue. 3/ cacert.pem I think this shouldn't be package, isn't the system one enough (ca-certificates) ? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zFKflrYyqY&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review