[Bug 959165] Review Request: mate-file-manager-share - Easy sharing folder via Samba (CIFS protocol)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=959165

--- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5329317

$ rpmlint -i -v *
mate-file-manager-share.i686: I: checking
mate-file-manager-share.i686: W: spelling-error %description -l en_US Caja ->
Cara, Cajun
The value of this tag appears to be misspelled. Please double-check.

mate-file-manager-share.i686: I: checking-url http://pub.mate-desktop.org
(timeout 10 seconds)
mate-file-manager-share.i686: W: conffile-without-noreplace-flag
/etc/samba/caja-share-smb.conf.example
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

mate-file-manager-share.src: I: checking
mate-file-manager-share.src: W: spelling-error %description -l en_US Caja ->
Cara, Cajun
The value of this tag appears to be misspelled. Please double-check.

mate-file-manager-share.src: I: checking-url http://pub.mate-desktop.org
(timeout 10 seconds)
mate-file-manager-share.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line
13, tab: line 1)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

mate-file-manager-share.src: I: checking-url
http://pub.mate-desktop.org/releases/1.6/mate-file-manager-share-1.6.0.tar.xz
(timeout 10 seconds)
mate-file-manager-share.x86_64: I: checking
mate-file-manager-share.x86_64: W: spelling-error %description -l en_US Caja ->
Cara, Cajun
The value of this tag appears to be misspelled. Please double-check.

mate-file-manager-share.x86_64: I: checking-url http://pub.mate-desktop.org
(timeout 10 seconds)
mate-file-manager-share.x86_64: W: conffile-without-noreplace-flag
/etc/samba/caja-share-smb.conf.example
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

mate-file-manager-share-debuginfo.i686: I: checking
mate-file-manager-share-debuginfo.i686: I: checking-url
http://pub.mate-desktop.org (timeout 10 seconds)
mate-file-manager-share-debuginfo.x86_64: I: checking
mate-file-manager-share-debuginfo.x86_64: I: checking-url
http://pub.mate-desktop.org (timeout 10 seconds)
mate-file-manager-share.spec:13: W: mixed-use-of-spaces-and-tabs (spaces: line
13, tab: line 1)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

mate-file-manager-share.spec: I: checking-url
http://pub.mate-desktop.org/releases/1.6/mate-file-manager-share-1.6.0.tar.xz
(timeout 10 seconds)
5 packages and 1 specfiles checked; 0 errors, 7 warnings.


Usually we append (noreplace) to almost all global config files in /etc.
However, in this case we have an example file which is not used directly.
Nevertheless, the appendix wouldn't break anything, so just add it.

Please don't mix tabs and spaces. I recommend spaces, so that your spec looks
the same in any text editor, independent from the configured tab width.


Besides that, your package looks fine. Well, I was a bit mislead by the
requirements. First I thought a runtime requirement for
mate-file-manager-extensions was missing, but this is strangely pulled in by
mate-file-manager. I hadn't expected this behavior.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x9M0fDVuxv&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]