Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958149 --- Comment #2 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Thank you for initial comments: (In reply to comment 1:) > - Is there a reason you've got LGPLv3+ instead of LGPLv2+ , > and GPLv3+ instead of GPLv2+? Because of libraries it links against? Because I firstly packaged development version 1.7.38, then later I decided to use stable version 1.6.49 instead (to use stabilized API/ABI on Fedora)... Changed. > - I don't think filter.pl should get installed/packaged. I removed this. >- Have you contacted upstream about fixing the FSF address? Actually this is already fixed in 1.7.x. > - Looks like a number of linking issues in rpmlint output. > libCHART probably need to link against libFOX, > not link against a bunch of other libraries. libCHART.so is modified not to contain non-weak undefined symbols. rpmlint still complains about unused libraries' dependency, however linking against libFOX.so will create these anyway and this should not be a blocker. > - Ask upstream why libFOX calls exit(). This should not be a blocker. Anyway libFOX.so may exit() at the very initial setup process (mainly when parsing command line option), not after such setup is done, and seems safe. Also there are some other toolkit-like libraries calling exit() in some situation (line GLib). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m0AP9Ng1zq&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review