Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957568 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@xxxxxxxx | |m --- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- %build # Remove CFLAGS=... for noarch packages (unneeded) CFLAGS="%{optflags}" %{__python} setup.py build Your package is noarch, so the CFLAGS statement is unneeded, as the spec template says. %files ... /usr/bin/pc_query /usr/bin/pycard-import /usr/bin/pycardsyncer Use macros instead of hardcoded paths: %{_bindir}/pc_query %{_bindir}/pycard-import %{_bindir}/pycardsyncer Please remove the upstream provided egginfo so that it gets rebuilt. See the packaging guidelines: http://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs Your packages doesn't ship documentation. Add README.rst as %doc. The source rpm is not built from the spec file provided by you. The %changelog is empty. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5kv2P9quSy&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review