Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910233 Patrick Uiterwijk <puiterwijk@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |puiterwijk@xxxxxxxxx Flags| |fedora-review+ --- Comment #8 from Patrick Uiterwijk <puiterwijk@xxxxxxxxx> --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License CC-BY-SA OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. NO, See below - Sources match upstream sha256sum: 2e7cf43c098c3d8f15d9e764bac51228aa29eceb64ae6f482175884c24e68d7a GeoLiteCityv6.dat.gz ab9c4deee7b3ef8bd665db67f2ba312b61d3aeb0233e8b2277f8cfbb9d7f2e6e GeoLiteCityv6.dat.gz OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. NO, See below - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) NO, See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag NO, See below - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. The checksum mismatch is because this package has been updated again since the last submit, which is my mistake. You do not have to re-do it for the review. 2. It does own %{_datadir}/GeoIP/, but as indicated in the spec file, this is an exception from the default rules. 3. RPMlint output: Checking: geoip-geolite-2013.04-1.fc18.noarch.rpm geoip-geolite.noarch: W: spelling-error Summary(en_US) geolocation -> echolocation, collocation, allocation geoip-geolite.noarch: W: spelling-error %description -l en_US geolocation -> echolocation, collocation, allocation 1 packages and 0 specfiles checked; 0 errors, 2 warnings. I couldn't care less about the spelling mistakes ;). Please make sure to update this package regularly, because it might be important when people start depending on it. This package is APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=O3aHqBIFsM&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review