Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910235 Patrick Uiterwijk <puiterwijk@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #3 from Patrick Uiterwijk <puiterwijk@xxxxxxxxx> --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. NO, See below - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License LGPLv3+ OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream sha256sum: e86058479b3820bd08f51b64e22c59fe1ed45ec468d51d36acd5ed413e49e810 pygeoip-0.2.6.zip e86058479b3820bd08f51b64e22c59fe1ed45ec468d51d36acd5ed413e49e810 pygeoip-0.2.6.zip OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) NO, See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. The %check part has $-style macros, please fix this before shipping it 2. python-pygeoip.noarch: W: spelling-error %description -l en_US instantiation -> instantiate, substantiation, installation python-pygeoip.noarch: W: spelling-error %description -l en_US mmap -> map, m map, mamma python-pygeoip.noarch: W: spelling-error %description -l en_US gi -> GI, guy, gee python-pygeoip.noarch: W: spelling-error %description -l en_US GeoIP -> George python-pygeoip.noarch: W: spelling-error %description -l en_US geoip -> George python-pygeoip.noarch: W: spelling-error %description -l en_US dat -> DAT, tad, sat python-pygeoip.noarch: W: spelling-error %description -l en_US lookup -> lockup, hookup, look up python-pygeoip.noarch: W: spelling-error %description -l en_US google -> Google, goggle, googly python-pygeoip.noarch: W: spelling-error %description -l en_US addr -> add, adder, adds python-pygeoip.noarch: W: spelling-error %description -l en_US dma -> dam, ma, mad python-pygeoip.noarch: W: install-file-in-docs /usr/share/doc/python-pygeoip-0.2.6/INSTALL python3-pygeoip.noarch: W: spelling-error %description -l en_US instantiation -> instantiate, substantiation, installation python3-pygeoip.noarch: W: spelling-error %description -l en_US mmap -> map, m map, mamma python3-pygeoip.noarch: W: spelling-error %description -l en_US gi -> GI, guy, gee python3-pygeoip.noarch: W: spelling-error %description -l en_US GeoIP -> George python3-pygeoip.noarch: W: spelling-error %description -l en_US geoip -> George python3-pygeoip.noarch: W: spelling-error %description -l en_US dat -> DAT, tad, sat python3-pygeoip.noarch: W: spelling-error %description -l en_US lookup -> lockup, hookup, look up python3-pygeoip.noarch: W: spelling-error %description -l en_US google -> Google, goggle, googly python3-pygeoip.noarch: W: spelling-error %description -l en_US addr -> add, adder, adds python3-pygeoip.noarch: W: spelling-error %description -l en_US dma -> dam, ma, mad python3-pygeoip.noarch: W: install-file-in-docs /usr/share/doc/python3-pygeoip-0.2.6/INSTALL 2 packages and 0 specfiles checked; 0 errors, 22 warnings. The spelling errors are to be expected. I would prefer that you did not ship INSTALL in the doc though. Please do not ship this package until geoip-geolite is shipped, or ship them together. Also, please fix the macro style in %check. Besides these, this package is APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Kxs31KjpCv&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review