Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #5 from Ding-Yi Chen <dchen@xxxxxxxxxx> --- Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines javadoc sub package cannot be installed. Please remove %{?_isa} from Requires: %{name}%{?_isa} = %{version}-%{release} Because %{?_isa} is for indicating dependency should be arch-specific, which is not for noarch packages. - Packages have proper BuildRequires/Requires on jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java BuildRequires: java-devel is missing - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No /usr/share/javadoc/zanata-common found See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation All the javadoc should be placed under directory of /usr/share/javadoc/zanata-common - Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros Choose either %{buildroot} or $RPM_BUILD_ROOT, they are the same thing. - : License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/dchen/958006-zanata- Change license to LGPLv2+ Output of rpmlint ---------------------- 1. zanata-common-javadoc.noarch: E: description-line-too-long C zanata-common-util, zanatzanata-common-javadoc.noarch: Use linebreak to split the description. 2. zanata-common.src:90: W: macro-in-comment %setup There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. zanata-common.src:90: W: macro-in-comment %{name} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. zanata-common.src:21: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 21) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. Regards, -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KoBSUNzkHe&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review