Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nrg2iso - Convert Nero Burning Rom image files into ISO https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231174 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-03-06 19:36 EST ------- GOOD - rpmlint is silent on source and binary rpm - package meets naming guidelines - package meets packaging guidelines - license (GPL ) OK, text in %doc (as gpl.txt), matches source - spec file legible, in am. english - source matches upstream, is latest version, sha1sum 26dfa9b489c9165dbc578ef3fddf6e491349df12 nrg2iso-0.4.tar.gz - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all files/directories that it creates, does not take ownership of foreign files/directories - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs (no docs at all but the GPL license and a very very short Changelog) - nothing in %doc affects runtime - not a GUI so no need for .desktop file - no libtool,pkgconfig,static files - no scriptlets - no need for separate -devel SHOULD - builds fine in mock for Centos-4/x86, Fedora 6 and devel/x86 - runs OK in Centos 4 and FC6 Package APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review