Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949311 Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- For 0.9.2-1: * License tag - The license is MIT, not BSD. * Build failure - Does not build on either F-20 or F-19: http://koji.fedoraproject.org/koji/taskinfo?taskID=5325042 http://koji.fedoraproject.org/koji/taskinfo?taskID=5325043 Seems python-nose, python3-nose are needed for BR. However even with these, %check still "really" fails randomly: http://koji.fedoraproject.org/koji/taskinfo?taskID=5325084 * $RPM_BUILD_ROOT v.s. %buildroot https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS - Please choose one style and aviod using both style. * No longer needed stuff https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRoot_tag - Cleaning up %buildroot at the beginning of %install is no longer needed (on Fedora). * Suggestions * Same summary / description for python2 and python3 version package - At least it is preferable to distinguish python2 and python3 version of the packages in %description. * Needed documentations - Is "test" directory needed for "documentation"? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8gK1xZALLZ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review