[Bug 957622] Review Request: perl-Twiggy - AnyEvent HTTP server for PSGI (like Thin)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957622

--- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> ---
The package uses bundled inc::Module::Install, either buildrequire all its
actual dependencies (preferred, listed below) or buildrequire
perl(inc::Module::Install) and delete tne inc directory.

perl(base)
perl(Carp)
perl(Config)
perl(Cwd)
perl(ExtUtils::MM_Unix)
perl(Fcntl)
perl(File::Find)
perl(File::Path)
perl(FindBin)
perl(Pod::Text)
perl(strict)
perl(vars)

In addition to those, you're missing many other used in Twiggy code and/or the
test suite (some are shared with inc::Module::Install):

perl(AnyEvent::AIO)
perl(AnyEvent::Handle)
perl(AnyEvent::Socket)
perl(AnyEvent::Util)
perl(base)
perl(Carp)
perl(constant)
perl(Errno)
perl(FindBin)
perl(HTTP::Request)
perl(HTTP::Request::Common)
perl(HTTP::Response)
perl(IO::AIO)
perl(IO::Handle)
perl(IO::Socket::INET)
perl(IO::Uncompress::Gunzip)
perl(LWP::UserAgent)
perl(parent)
perl(Plack::App::File)
perl(Plack::HTTPParser)
perl(Plack::Loader)
perl(Plack::Request)
perl(Plack::Test::Suite)
perl(Plack::Util)
perl(Scalar::Util)
perl(Socket)
perl(warnings)

Consider packaging Plack::Middleware::Deflater too, so the deflater.t tests get
executed.

You can drop perl(HTTP::Status) and perl(Try::Tiny) from your runtime dep list.
 RPM finds those automatically.  perl(AnyEvent::AIO) and perl(IO::AIO), on the
other hand, don't get auto-detected and you need to require them explicitly.

Oh, and perhaps some users would find the examples in the 'eg' directory
useful?...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LNfiKJE7ah&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]