Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #51 from Brendan Jones <brendan.jones.it@xxxxxxxxx> --- OK, this scratch builds OK, so I'm not going to worry about th install log in fedora-review Just two things: * all of your sub-packages need to Require razorqt-data such that the license is always installed. * could clean up your change log and commetns. Use %% where appropriate and you've got some double hyphenating I'm used to seeing the %description right after the %package declaration but thats a matter of style. You could also consider using an epoch to trump the razorqt repo, but thats entirely up to you. Fix the license requires and I'll approve. Good job Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - Package installs a %{name}.desktop using desktop-file-install if there is such a file. See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. Make sure macros are escaped with %% and you have some double hypenating going on [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libqtxdg , libqtxdg-devel , razorqt-devel , razorqt-data , razorqt-about , razorqt- appswitcher , lightdm-razorqt , razorqt-theme-amego , razorqt-theme- ambiance , razorqt-theme-green , razorqt-theme-light , razorqt-themes [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "LGPL (v2 or later)", "Unknown or generated", "*No copyright* WTFPL WTFPL (v2)", "LGPL (v2.1 or later)", "GPL (v3)", "GPL (v2)". 7 files have unknown license. Detailed output of licensecheck in /home/bsjones/review-razorqt/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked when required Note: desktop file(s) in razorqt-about, razorqt-appswitcher, lightdm- razorqt [x]: Useful -debuginfo package or justification otherwise. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 112640 bytes in 13 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3358720 bytes in /usr/share 296960 razorqt-session-0.5.2-6.fc18.x86_64.rpm 337920 razorqt- libs-0.5.2-6.fc18.x86_64.rpm 491520 razorqt- desktop-0.5.2-6.fc18.x86_64.rpm 81920 razorqt- runner-0.5.2-6.fc18.x86_64.rpm 81920 lightdm- razorqt-0.5.2-6.fc18.x86_64.rpm 204800 razorqt- notifications-0.5.2-6.fc18.x86_64.rpm 122880 razorqt- globalkeyshortcuts-0.5.2-6.fc18.x86_64.rpm 184320 razorqt- config-0.5.2-6.fc18.x86_64.rpm 71680 razorqt-policykit- agent-0.5.2-6.fc18.x86_64.rpm 51200 libqtxdg-0.5.2-6.fc18.x86_64.rpm 1034240 razorqt-panel-0.5.2-6.fc18.x86_64.rpm 266240 razorqt- autosuspend-0.5.2-6.fc18.x86_64.rpm 10240 razorqt- about-0.5.2-6.fc18.x86_64.rpm 61440 razorqt-power-0.5.2-6.fc18.x86_64.rpm 61440 razorqt-openssh-askpass-0.5.2-6.fc18.x86_64.rpm [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.1.31 starting... Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Mock Version: 1.1.31 INFO: Mock Version: 1.1.31 Start: lock buildroot INFO: installing package(s): /home/bsjones/review-razorqt/results/razorqt-0.5.2-6.fc18.x86_64.rpm /home/bsjones/review-razorqt/results/libqtxdg-0.5.2-6.fc18.x86_64.rpm /home/bsjones/review-razorqt/results/libqtxdg-devel-0.5.2-6.fc18.x86_64.rpm /home/bsjones/review-razorqt/results/razorqt-devel-0.5.2-6.fc18.x86_64.rpm /home/bsjones/review-razorqt/results/razorqt-data-0.5.2-6.fc18.noarch.rpm /home/bsjones/review-razorqt/results/razorqt-about-0.5.2-6.fc18.x86_64.rpm /home/bsjones/review-razorqt/results/razorqt-appswitcher-0.5.2-6.fc18.x86_64.rpm /home/bsjones/review-razorqt/results/lightdm-razorqt-0.5.2-6.fc18.x86_64.rpm /home/bsjones/review-razorqt/results/razorqt-theme-amego-0.5.2-6.fc18.noarch.rpm /home/bsjones/review-razorqt/results/razorqt-theme-ambiance-0.5.2-6.fc18.noarch.rpm /home/bsjones/review-razorqt/results/razorqt-theme-green-0.5.2-6.fc18.noarch.rpm /home/bsjones/review-razorqt/results/razorqt-theme-light-0.5.2-6.fc18.noarch.rpm /home/bsjones/review-razorqt/results/razorqt-themes-0.5.2-6.fc18.noarch.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-18-x86_64/root/', 'install', '/home/bsjones/review-razorqt/results/razorqt-0.5.2-6.fc18.x86_64.rpm', '/home/bsjones/review-razorqt/results/libqtxdg-0.5.2-6.fc18.x86_64.rpm', '/home/bsjones/review-razorqt/results/libqtxdg-devel-0.5.2-6.fc18.x86_64.rpm', '/home/bsjones/review-razorqt/results/razorqt-devel-0.5.2-6.fc18.x86_64.rpm', '/home/bsjones/review-razorqt/results/razorqt-data-0.5.2-6.fc18.noarch.rpm', '/home/bsjones/review-razorqt/results/razorqt-about-0.5.2-6.fc18.x86_64.rpm', '/home/bsjones/review-razorqt/results/razorqt-appswitcher-0.5.2-6.fc18.x86_64.rpm', '/home/bsjones/review-razorqt/results/lightdm-razorqt-0.5.2-6.fc18.x86_64.rpm', '/home/bsjones/review-razorqt/results/razorqt-theme-amego-0.5.2-6.fc18.noarch.rpm', '/home/bsjones/review-razorqt/results/razorqt-theme-ambiance-0.5.2-6.fc18.noarch.rpm', '/home/bsjones/review-razorqt/results/razorqt-theme-green-0.5.2-6.fc18.noarch.rpm', '/home/bsjones/review-razorqt/results/razorqt-theme-light-0.5.2-6.fc18.noarch.rpm', '/home/bsjones/review-razorqt/results/razorqt-themes-0.5.2-6.fc18.noarch.rpm'] Error: Package: razorqt-0.5.2-6.fc18.x86_64 (/razorqt-0.5.2-6.fc18.x86_64) Requires: razorqt-desktop = 0.5.2-6.fc18 Error: Package: razorqt-0.5.2-6.fc18.x86_64 (/razorqt-0.5.2-6.fc18.x86_64) Requires: razorqt-notifications = 0.5.2-6.fc18 Error: Package: razorqt-appswitcher-0.5.2-6.fc18.x86_64 (/razorqt-appswitcher-0.5.2-6.fc18.x86_64) Requires: librazorqxt.so.0()(64bit) Error: Package: lightdm-razorqt-0.5.2-6.fc18.x86_64 (/lightdm-razorqt-0.5.2-6.fc18.x86_64) Requires: librazorqt.so.0()(64bit) Error: Package: razorqt-about-0.5.2-6.fc18.x86_64 (/razorqt-about-0.5.2-6.fc18.x86_64) Requires: librazorqt.so.0()(64bit) Error: Package: razorqt-0.5.2-6.fc18.x86_64 (/razorqt-0.5.2-6.fc18.x86_64) Requires: razorqt-config = 0.5.2-6.fc18 Error: Package: razorqt-0.5.2-6.fc18.x86_64 (/razorqt-0.5.2-6.fc18.x86_64) Requires: razorqt-session = 0.5.2-6.fc18 Error: Package: razorqt-appswitcher-0.5.2-6.fc18.x86_64 (/razorqt-appswitcher-0.5.2-6.fc18.x86_64) Requires: librazorqt.so.0()(64bit) Error: Package: razorqt-0.5.2-6.fc18.x86_64 (/razorqt-0.5.2-6.fc18.x86_64) Requires: razorqt-runner = 0.5.2-6.fc18 Error: Package: razorqt-devel-0.5.2-6.fc18.x86_64 (/razorqt-devel-0.5.2-6.fc18.x86_64) Requires: librazormount.so.0()(64bit) You could try using --skip-broken to work around the problem Error: Package: razorqt-0.5.2-6.fc18.x86_64 (/razorqt-0.5.2-6.fc18.x86_64) Requires: razorqt-globalkeyshortcuts = 0.5.2-6.fc18 Error: Package: razorqt-0.5.2-6.fc18.x86_64 (/razorqt-0.5.2-6.fc18.x86_64) Requires: razorqt-power = 0.5.2-6.fc18 Error: Package: razorqt-0.5.2-6.fc18.x86_64 (/razorqt-0.5.2-6.fc18.x86_64) Requires: razorqt-policykit-agent = 0.5.2-6.fc18 Error: Package: razorqt-0.5.2-6.fc18.x86_64 (/razorqt-0.5.2-6.fc18.x86_64) Requires: razorqt-autosuspend = 0.5.2-6.fc18 Error: Package: razorqt-devel-0.5.2-6.fc18.x86_64 (/razorqt-devel-0.5.2-6.fc18.x86_64) Requires: librazorqxt.so.0()(64bit) Error: Package: razorqt-devel-0.5.2-6.fc18.x86_64 (/razorqt-devel-0.5.2-6.fc18.x86_64) Requires: razorqt-libs(x86-64) = 0.5.2-6.fc18 Error: Package: razorqt-devel-0.5.2-6.fc18.x86_64 (/razorqt-devel-0.5.2-6.fc18.x86_64) Requires: librazorqt.so.0()(64bit) Error: Package: razorqt-0.5.2-6.fc18.x86_64 (/razorqt-0.5.2-6.fc18.x86_64) Requires: razorqt-panel = 0.5.2-6.fc18 Error: Package: razorqt-0.5.2-6.fc18.x86_64 (/razorqt-0.5.2-6.fc18.x86_64) Requires: razorqt-openssh-askpass = 0.5.2-6.fc18 You could try running: rpm -Va --nofiles --nodigest Rpmlint ------- Checking: razorqt-0.5.2-6.fc18.x86_64.rpm libqtxdg-0.5.2-6.fc18.x86_64.rpm libqtxdg-devel-0.5.2-6.fc18.x86_64.rpm razorqt-devel-0.5.2-6.fc18.x86_64.rpm razorqt-data-0.5.2-6.fc18.noarch.rpm razorqt-about-0.5.2-6.fc18.x86_64.rpm razorqt-appswitcher-0.5.2-6.fc18.x86_64.rpm lightdm-razorqt-0.5.2-6.fc18.x86_64.rpm razorqt-theme-amego-0.5.2-6.fc18.noarch.rpm razorqt-theme-ambiance-0.5.2-6.fc18.noarch.rpm razorqt-theme-green-0.5.2-6.fc18.noarch.rpm razorqt-theme-light-0.5.2-6.fc18.noarch.rpm razorqt-themes-0.5.2-6.fc18.noarch.rpm razorqt.x86_64: E: no-binary razorqt.x86_64: W: no-documentation libqtxdg-devel.x86_64: W: no-documentation razorqt-devel.x86_64: W: spelling-error %description -l en_US amongst -> among st, among-st, among razorqt-devel.x86_64: W: no-documentation razorqt-devel.x86_64: W: no-manual-page-for-binary razor-x11info razorqt-about.x86_64: W: no-documentation razorqt-about.x86_64: W: no-manual-page-for-binary razor-about razorqt-appswitcher.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure razorqt-appswitcher.x86_64: W: no-documentation razorqt-appswitcher.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/razor-appswitcher.desktop razorqt-appswitcher.x86_64: W: no-manual-page-for-binary razor-appswitcher lightdm-razorqt.x86_64: W: no-documentation lightdm-razorqt.x86_64: W: no-manual-page-for-binary razor-lightdm-greeter razorqt-theme-amego.noarch: W: spelling-error Summary(en_US) mego -> MEGO, meg, ego razorqt-theme-amego.noarch: W: spelling-error %description -l en_US mego -> MEGO, meg, ego razorqt-theme-amego.noarch: W: no-documentation razorqt-theme-ambiance.noarch: W: no-documentation razorqt-theme-green.noarch: W: no-documentation razorqt-theme-light.noarch: W: no-documentation razorqt-themes.noarch: W: no-documentation 13 packages and 0 specfiles checked; 1 errors, 20 warnings. Requires -------- razorqt-theme-light (rpmlib, GLIBC filtered): razorqt-data razorqt (rpmlib, GLIBC filtered): razorqt-about razorqt-appswitcher razorqt-autosuspend razorqt-config razorqt-data razorqt-desktop razorqt-globalkeyshortcuts razorqt-notifications razorqt-openssh-askpass razorqt-panel razorqt-policykit-agent razorqt-power razorqt-runner razorqt-session razorqt-theme-ambiance (rpmlib, GLIBC filtered): razorqt-data razorqt-about (rpmlib, GLIBC filtered): libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtXml.so.4()(64bit) libX11.so.6()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libmagic.so.1()(64bit) libqtxdg.so.0()(64bit) librazorqt.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) razorqt-data rtld(GNU_HASH) libqtxdg-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libqtxdg(x86-64) libqtxdg.so.0()(64bit) razorqt-data (rpmlib, GLIBC filtered): config(razorqt-data) razorqt-theme-light redhat-menus razorqt-theme-green (rpmlib, GLIBC filtered): razorqt-data razorqt-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtXml.so.4()(64bit) libX11.so.6()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libmagic.so.1()(64bit) libqtxdg.so.0()(64bit) librazormount.so.0()(64bit) librazorqt.so.0()(64bit) librazorqxt.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) razorqt-libs(x86-64) rtld(GNU_HASH) razorqt-themes (rpmlib, GLIBC filtered): razorqt-theme-ambiance razorqt-theme-amego razorqt-theme-green razorqt-theme-light razorqt-theme-amego (rpmlib, GLIBC filtered): razorqt-data libqtxdg (rpmlib, GLIBC filtered): /sbin/ldconfig libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtXml.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libmagic.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) lightdm-razorqt (rpmlib, GLIBC filtered): /bin/sh /usr/sbin/update-alternatives libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtXml.so.4()(64bit) libX11.so.6()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) liblightdm-qt-2.so.0()(64bit) libm.so.6()(64bit) libmagic.so.1()(64bit) libqtxdg.so.0()(64bit) librazorqt.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) lightdm razorqt-data rtld(GNU_HASH) razorqt-appswitcher (rpmlib, GLIBC filtered): libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtXml.so.4()(64bit) libX11.so.6()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libmagic.so.1()(64bit) libqtxdg.so.0()(64bit) librazorqt.so.0()(64bit) librazorqxt.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) razorqt-data rtld(GNU_HASH) Provides -------- razorqt-theme-light: razorqt-theme razorqt-theme-light razorqt: razorqt razorqt(x86-64) razorqt-theme-ambiance: razorqt-theme razorqt-theme-ambiance razorqt-about: razorqt-about razorqt-about(x86-64) libqtxdg-devel: libqtxdg-devel libqtxdg-devel(x86-64) pkgconfig(qtxdg) razorqt-data: config(razorqt-data) razorqt-data razorqt-theme-green: razorqt-theme razorqt-theme-green razorqt-devel: pkgconfig(razormount) pkgconfig(razorqt) pkgconfig(razorqxt) razorqt-devel razorqt-devel(x86-64) razorqt-themes: razorqt-themes razorqt-theme-amego: razorqt-theme razorqt-theme-amego libqtxdg: libqtxdg libqtxdg(x86-64) libqtxdg.so.0()(64bit) lightdm-razorqt: lightdm-greeter lightdm-razorqt lightdm-razorqt(x86-64) razorqt-appswitcher: razorqt-appswitcher razorqt-appswitcher(x86-64) MD5-sum check ------------- http://razor-qt.org/downloads/razorqt-0.5.2.tar.bz2 : CHECKSUM(SHA256) this package : ac8a890eba7a24a20a2c0ea7a5020c6001853997c1e1b1b927ff4700b0e0e1ad CHECKSUM(SHA256) upstream package : ac8a890eba7a24a20a2c0ea7a5020c6001853997c1e1b1b927ff4700b0e0e1ad Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-18-x86_64 Command line :/usr/bin/fedora-review -m fedora-18-x86_64 -n razorqt -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s3EwfFluME&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review