Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956201 --- Comment #5 from Volker Fröhlich <volker27@xxxxxx> --- Ship AUTHORS, NEWS and COPYING as documentation! As far as I can see, InsightToolkit-examples is not a BR; Neither is graphviz. Prefer .tar.gz, as it is slightly smaller. You can use the name macro in Source0. Please find other comments inline below. Cosmetics: - You can remove the slash in "%{buildroot}/%{_datadir}" - Insert an empty line between the two paragraphs of the description Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= [!]: Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /media/speicher1/makerpm/956201-nifti2dicom/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL That's the outcome of getting a tarball for a Git tag. The resulting file has a different name. I don't know if something can be done about that. ===== MUST items ===== C/C++: [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [-]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [-]: Development files must be in a -devel package [-]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [!]: Package is not known to require ExcludeArch. Due to missing InsightToolkit builds don't succeed on PPC/PPC64 at the moment. The cause is a missing gdcm build. I haven't investigated ARM, but it doesn't have InsightToolkit either. I informed the maintainer of gdcm and InsightToolkit. If that can't be settled somehow, you should add an ExcludeArch tag. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /media/speicher1/makerpm/956201-nifti2dicom/licensecheck.txt [!]: Package consistently uses macro is (instead of hard-coded directory names). Use mandir instead of datadir/man [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [-]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [!]: Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /media/speicher1/makerpm/956201-nifti2dicom/diff.txt See above! [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Useful -debuginfo package or justification otherwise. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: Package functions as described. Haven't tried yet [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. [!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (v0.4.5.zip) I'm not sure you can do anything about that. [x]: SourceX is a working URL. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: Package should compile and build into binary rpms on all supported architectures. See "ExcludeArch"! [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: nifti2dicom-0.4.5-3.fc20.x86_64.rpm nifti2dicom-debuginfo-0.4.5-3.fc20.x86_64.rpm nifti2dicom-0.4.5-3.fc20.src.rpm nifti2dicom.src:83: W: macro-in-%changelog %doc 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint nifti2dicom nifti2dicom-debuginfo 2 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- nifti2dicom-0.4.5-3.fc20.x86_64.rpm (rpmlib, GLIBC filtered): /bin/sh libICE.so.6()(64bit) libITKBiasCorrection-4.3.so.1()(64bit) libITKBioCell-4.3.so.1()(64bit) libITKCommon-4.3.so.1()(64bit) libITKDICOMParser-4.3.so.1()(64bit) libITKDeprecated-4.3.so.1()(64bit) libITKEXPAT-4.3.so.1()(64bit) libITKFEM-4.3.so.1()(64bit) libITKGDCM-4.3.so.1()(64bit) libITKIOBMP-4.3.so.1()(64bit) libITKIOBioRad-4.3.so.1()(64bit) libITKIOCSV-4.3.so.1()(64bit) libITKIOGDCM-4.3.so.1()(64bit) libITKIOGE-4.3.so.1()(64bit) libITKIOGIPL-4.3.so.1()(64bit) libITKIOHDF5-4.3.so.1()(64bit) libITKIOIPL-4.3.so.1()(64bit) libITKIOImageBase-4.3.so.1()(64bit) libITKIOJPEG-4.3.so.1()(64bit) libITKIOMesh-4.3.so.1()(64bit) libITKIOMeta-4.3.so.1()(64bit) libITKIONIFTI-4.3.so.1()(64bit) libITKIONRRD-4.3.so.1()(64bit) libITKIOPNG-4.3.so.1()(64bit) libITKIOSiemens-4.3.so.1()(64bit) libITKIOSpatialObjects-4.3.so.1()(64bit) libITKIOStimulate-4.3.so.1()(64bit) libITKIOTIFF-4.3.so.1()(64bit) libITKIOTransformBase-4.3.so.1()(64bit) libITKIOTransformHDF5-4.3.so.1()(64bit) libITKIOTransformInsightLegacy-4.3.so.1()(64bit) libITKIOTransformMatlab-4.3.so.1()(64bit) libITKIOVTK-4.3.so.1()(64bit) libITKIOXML-4.3.so.1()(64bit) libITKKLMRegionGrowing-4.3.so.1()(64bit) libITKLabelMap-4.3.so.1()(64bit) libITKMesh-4.3.so.1()(64bit) libITKMetaIO-4.3.so.1()(64bit) libITKNrrdIO-4.3.so.1()(64bit) libITKOptimizers-4.3.so.1()(64bit) libITKOptimizersv4-4.3.so.1()(64bit) libITKPath-4.3.so.1()(64bit) libITKPolynomials-4.3.so.1()(64bit) libITKQuadEdgeMesh-4.3.so.1()(64bit) libITKReview-4.3.so.1()(64bit) libITKSpatialObjects-4.3.so.1()(64bit) libITKStatistics-4.3.so.1()(64bit) libITKVNLInstantiation-4.3.so.1()(64bit) libITKVTK-4.3.so.1()(64bit) libITKVideoCore-4.3.so.1()(64bit) libITKVideoIO-4.3.so.1()(64bit) libITKWatersheds-4.3.so.1()(64bit) libITKgiftiio-4.3.so.1()(64bit) libITKniftiio-4.3.so.1()(64bit) libITKznz-4.3.so.1()(64bit) libQVTK.so.5.10()(64bit) libQtCore.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSql.so.4()(64bit) libQtWebKit.so.4()(64bit) libQtXmlPatterns.so.4()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgdcmDICT.so.2.0()(64bit) libgdcmMSFF.so.2.0()(64bit) libhdf5.so.7()(64bit) libhdf5_cpp.so.7()(64bit) libitkNetlibSlatec-4.3.so.1()(64bit) libitkopenjpeg-4.3.so.1()(64bit) libitksys-4.3.so.1()(64bit) libjpeg.so.62()(64bit) libm.so.6()(64bit) libnetlib.so.1.14()(64bit) libpng15.so.15()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libtiff.so.5()(64bit) libv3p_netlib.so.1.14()(64bit) libvcl.so.1.14()(64bit) libvnl.so.1.14()(64bit) libvnl_algo.so.1.14()(64bit) libvtkCommon.so.5.10()(64bit) libvtkFiltering.so.5.10()(64bit) libvtkGraphics.so.5.10()(64bit) libvtkHybrid.so.5.10()(64bit) libvtkIO.so.5.10()(64bit) libvtkImaging.so.5.10()(64bit) libvtkInfovis.so.5.10()(64bit) libvtkParallel.so.5.10()(64bit) libvtkRendering.so.5.10()(64bit) libvtkViews.so.5.10()(64bit) libvtkVolumeRendering.so.5.10()(64bit) libvtkWidgets.so.5.10()(64bit) libvtksys.so.5.10()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) nifti2dicom-debuginfo-0.4.5-3.fc20.x86_64.rpm (rpmlib, GLIBC filtered): Provides -------- nifti2dicom-0.4.5-3.fc20.x86_64.rpm: nifti2dicom = 0.4.5-3.fc20 nifti2dicom(x86-64) = 0.4.5-3.fc20 nifti2dicom-debuginfo-0.4.5-3.fc20.x86_64.rpm: nifti2dicom-debuginfo = 0.4.5-3.fc20 nifti2dicom-debuginfo(x86-64) = 0.4.5-3.fc20 MD5-sum check ------------- https://github.com/biolab-unige/nifti2dicom/archive/v0.4.5.zip : CHECKSUM(SHA256) this package : 7d4815c9ffa92c803d598152af83aff40bfbab9688c30dc54e33c05f42759a20 CHECKSUM(SHA256) upstream package : e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 diff -r also reports differences Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 956201 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UXST3Xa50e&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review