Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957422 --- Comment #13 from Christopher Meng <cickumqt@xxxxxxxxx> --- (In reply to comment #10) > And what is it? > "install -p -D -m 755 bin/%{name} %{buildroot}%{_bindir}/%{name}" Oh..Forgot to remove it... > > > * change *-devel to pkgconfig(*) where it is possible (pkgconfig(QtGui), > > > pkgconfig(aspell), pkgconfig(hunspell), pkgconfig(libpng)). > > > > Why?(Not very understand) > > This is issue - not bug. > Using pkgconfig() make spec "packagename-independent". > You don't know how these packages will be named in next Fedora release or EL. I'll leave these things as I can know the next names ;) > "Make release" provides compiling without debug information. "Make debug" - > with it. > Just add "CONFIG += debug_and_release" to src.pro > This is issue too - not a bug. Let's fix bugs first, for such "issues" I think I can handle them later. > This is 10-sec action: > for i in f17 f18 f19 rawhide; do koji build --scratch $i <srpm>; done > Another usual tool - fedore-review: > fedora-review -r -n <srpm> I have to say fedora-review doesn't work on my machine, I tried to fix it. So...(In fact I also want to review your package) > So - last part of preview - 3rd parties. > If they are not modified - you must delete them and replace with linking to > shared ones. > minizip: ioapi.* zip.* unzip.* > quazip: qua*.* > zlib: zconf.h zlib.h This means I have to add BR like quazip/minizip-devel and zlib-devel. Bu now because the program use the bundled ones so a lot of errors come out. Should I asked upstream or fixed by myself? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qhXUSj3kD1&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review