Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=723326 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(eldy@destailleur. | |fr) --- Comment #5 from Jason Tibbitts <tibbs@xxxxxxxxxxx> --- I am triaging old review tickets. I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale. Please post a spec file so that people can look at without chasing down your srpm and unpacking it. Note a few rpmlint complaints: dolibarr.noarch: W: invalid-license GPL-3.0+ Please use a valid License: tag from https://fedoraproject.org/wiki/Licensing:Main dolibarr.noarch: E: incorrect-fsf-address /usr/share/dolibarr/htdocs/webservices/demo_wsclient_category.php-NORUN dolibarr.noarch: E: incorrect-fsf-address /usr/share/dolibarr/htdocs/cron/info.php dolibarr.noarch: E: incorrect-fsf-address /usr/share/dolibarr/htdocs/webservices/server_category.php Might want to fix these upstream. dolibarr.noarch: E: non-executable-script /usr/share/dolibarr/htdocs/includes/odtphp/odt2pdf.sh 0644L /bin/bash Why is there a shell script under htdocs? dolibarr.noarch: W: dangerous-command-in-%post rm dolibarr.noarch: W: dangerous-command-in-%postun rm You really shouldn't do this kind of thing. I unpacked the srpm to look at the scriptlets, and they are pretty much totally insane. scriptlets cannot produce output. You should include a sane configuration file in the package and not mess with it on package upgrades. The selinux stuff on the surface is OK, though if this package gets in you should communicate with the selinux team to get the necessary contexts into the default policy. Also, I don't think httpd_sys_script_rw_t is a valid context. Your scriptlets to restart things are completely improper. And I'm out of breath now. Throughout the spec you use macro forms for commands like "%{__chmod}". These should not be used; just say "chmod" instead. That's about all I have time for at the moment; there are plenty of other issues I can see, though. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8pTGB3hq2R&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review