Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957415 --- Comment #2 from Petr Šabata <psabata@xxxxxxxxxx> --- 0. The SRPM used in koji build referenced in Comment #1 differs from the one submitted for review. The one submitted here doesn't build. 1. Similarly to 'lookat', you'll need to regenerate upstream build files to support aarch64. However, calling autoreconf here fails on automake because some of the standard distribution files, namely AUTHORS and ChangeLog, are missing. Option #1: Ask upstream to include those files. Option #2: Force automake to use different strictness level, e.g. "foreign". See automake info page for details on this. 2. None of the source files mentions their license, neither do the README files. Both standard BSD 2-clause (./LICENSE) license and GPLv3 (./COPYING) are included. It's possible the project uses them both but please ask upstream for clarification. If both are really used, the correct License tag will be "BSD and GPLv3+". See the Licensing Guidelines for valid short names: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses 3. Build-time dependencies are incorrect. You can safely drop those: - glibc-devel - libstdc++-devel - libtool However, the following is necessary for the package to build: - openssl-devel 4. There's a test suite. Use it. (i.e., make a %check section which runs "make check") 5. Package COPYING in %doc as well, if relevant (after your resolve issue #2). 6. Summary -- Add "The". 7. %description -- Replace both "lnav" occurences with %{name}. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=loxDw17j0o&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review