Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951582 --- Comment #2 from Susi Lehtola <susi.lehtola@xxxxxx> --- (In reply to comment #1) > License tag needs "and MIT" for /usr/share/psi/python/pep8.py - Fixed. > /usr/share/psi/python/pep8.py permissions wrong, should be executable? I've fixed this in the upstream repo, the file shouldn't have a shebang. > Need versioned dependencies in subpackages Nope - since the package only contains static libraries, the devel package doesn't require the base package. The only relevant dependency is of the base package on -data, which is properly versioned. > Have you queried upstream about including a license text file? Yes, I've filed a bug upstream about missing license headers and a license file. I've also added a license text file in the upstream repo. > Need to upstream Patch2, or document why it shouldn't be I've already applied this upstream. > Unless intending to support RHEL5: > remove BuildRoot tag > remove rm -rf %{buildroot} from %install section > remove %defattr > remove %clean section Well, these don't hurt... but considering that the package anyway requires a recent version of Boost, I've dropped these. http://theory.physics.helsinki.fi/~jzlehtol/rpms/psi4.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/psi4-4.0-0.2.b4.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Mgr2XBb6Im&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review