Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957422 --- Comment #6 from Eugene A. Pivnev <ti.eugene@xxxxxxxxx> --- Short pre-review: = Errors = * Remove gcc-c++ from BR: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Exceptions_2 * Source0: double // * Use lang files: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Handling_Locale_Files) * %doc: images/ not used anywhere * licensecheck errors (incorrect FSF address) * precompiled translations (*.qm) in sources. Delete them and recreate witj lrelease. * PREFIX=%{_bindir} is not used. = Issues = * Koji builds for target distros. * change *-devel to pkgconfig(*) where it is possible (pkgconfig(QtGui), pkgconfig(aspell), pkgconfig(hunspell), pkgconfig(libpng)). * src.pro does not provides "make release". Now I want to explore bundled quazip, zlib, zip/unzip. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bMcwsExcow&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review