[Bug 950171] Review Request: librecad - Computer Assisted Design (CAD) Application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=950171

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx

--- Comment #1 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
FTBFS:
...
g++ -c -pipe -std=c++0x -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -O2 -Wall -W
-D_REENTRANT -DQC_APPKEY="/LibreCAD" -DQC_APPNAME="LibreCAD"
-DQC_COMPANYNAME="LibreCAD" -DQC_COMPANYKEY="LibreCAD" -DQC_VERSION="master"
-DQC_DELAYED_SPLASH_SCREEN=1 -DHAS_BOOST=1 -DQC_SCMREVISION="2.0.0beta2"
-DQC_APPDIR="librecad" -DQINITIMAGES_LIBRECAD=qInitImages_librecad
-DQT_NO_DEBUG -DQT_SVG_LIB -DQT_SQL_LIB -DQT_GUI_LIB -DQT_CORE_LIB -DQT_SHARED
-I/usr/lib64/qt4/mkspecs/linux-g++ -I. -I/usr/include/QtCore
-I/usr/include/QtGui -I/usr/include/QtSql -I/usr/include/QtSvg -I/usr/include
-I/usr/include/QtHelp -I/usr -I/usr/include/libdxfrw0
-I../../libraries/jwwlib/src -Icmd -Ilib/actions -Ilib/creation -Ilib/debug
-Ilib/engine -Ilib/fileio -Ilib/filters -Ilib/gui -Ilib/information -Ilib/math
-Ilib/modification -Ilib/scripting -Iactions -Imain -Iplugins -Iui -Iui/forms
-I../res -I../../generated/librecad/moc -I../../generated/librecad/ui -o
../../generated/librecad/obj/rs_preview.o lib/actions/rs_preview.cpp
In file included from lib/engine/rs_entitycontainer.h:33:0,
                 from lib/actions/rs_snapper.h:31,
                 from lib/actions/rs_actioninterface.h:33,
                 from lib/actions/rs_actioninterface.cpp:28:
lib/engine/rs_ellipse.h:32:29: fatal error: boost/version.hpp: No such file or
directory
 #include <boost/version.hpp>
                             ^
compilation terminated.
...

Seems as if BR: boost-devel is required.


2 other (minor) nits:

1) The muParser check/MUPARSER_DIR magic doesn't work:
...
make[1]: Entering directory
`/builddir/build/BUILD/LibreCAD-52669bf69231e8efd35e67689f5ad660ea9528b2/librecad'
cd src/ && /usr/lib64/qt4/bin/qmake
/builddir/build/BUILD/LibreCAD-52669bf69231e8efd35e67689f5ad660ea9528b2/librecad/src/src.pro
CONFIG+=release -o Makefile
Project MESSAGE: Using boost libraries in /usr.
Project MESSAGE: muParser was not found, please install muParser!
Project MESSAGE: Using muParser libraries in .
Project MESSAGE: We will be using CPP11 features
...

AFAIS, this is a defect in common.pro, which doesn't have any actual impact on
building, because the muParser files are implicitly picked up through default
paths.



2) Bogus -I... in compiler calls:
... -I/usr/include -I/usr ...

I haven't investigated in depth, but this kind of -I... change the inclusion
order and may trigger subtile issues. IMO, these also originate from faulty
qmake checks for some libs (Wild guess: boost).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zCvE75dpHy&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]