Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879932 --- Comment #14 from Volker Fröhlich <volker27@xxxxxx> --- (In reply to comment #8) > (In reply to comment #7) > > That piece of software is from 2003. I can see you're packaging it because > > rigsofrods requires it, but I'm a bit skeptic. It might be worth convincing > > upstream to turn away from it. > I think it is simple and works. So, why not use it? I'm totally fine with that. But bare in mind, if problems arise, you're probably left alone in solving them. > > Try to preserve the header timestamps by adding -p to install -c -m 644 *.h > > $(PREFIX_H) in src/Makefile > How you think it have worth by patching Makefile? > Then line below "install -c libSocketW.so.$(API_VER).$(SW_VER) > $(PREFIX)/lib" also should have -p flag? I think the exact timestamp is not relevant there, as these files are generated at build time. > I think it is not so serious issues to focus on its. It's only a "should". > > You could use the name macro for the patches. > Sorry, could you please explain what you mean and for what? e. g. Patch1: %{name}-1.2.0-do_something.patch -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J6OSShTM9u&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review