Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879932 --- Comment #8 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> --- (In reply to comment #7) > That piece of software is from 2003. I can see you're packaging it because > rigsofrods requires it, but I'm a bit skeptic. It might be worth convincing > upstream to turn away from it. I think it is simple and works. So, why not use it? > Try to preserve the header timestamps by adding -p to install -c -m 644 *.h > $(PREFIX_H) in src/Makefile How you think it have worth by patching Makefile? Then line below "install -c libSocketW.so.$(API_VER).$(SW_VER) $(PREFIX)/lib" also should have -p flag? > There's a compiler warning you might be able to solve. The exit call in the > library and the outdated FSF postal address in the license file should also > be addressed upstream. Given the age of this library, that's probably > hopeless. You are absolutely right! Meantime I had contact upstream and they answer me. Quoting: "Hi Pavel, That code is very old and isn't maintained any longer. However, you have my permission to update the license file if you wish. As I remember it the exit() calls should be easy to eliminate; isn't there a define in the code for throwing exceptions instead? Ah well, too long a time ago to remember :-) Regards, Anders Lindström" I think it is not so serious issues to focus on its. > You could use the name macro for the patches. Sorry, could you please explain what you mean and for what? > Consider to wrap the long changelog lines Ok. Except URL to do not break it. > Scriptlets (post, postun) are commonly placed after the install section, but > that's probably just convention. Ok, moved. > APPROVED Volker thank you very much for the review! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wtvumTx5gd&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review