[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=954108

--- Comment #5 from Antonio Trande <anto.trande@xxxxxxxxx> ---
- 'libjpeg-turbo-devel' is missing among BuildRequires 

- Your package doesn't build in mock on rawhide, it needs 'automake17'.

Also, 

- there are some warnings during configure tasks:

>configure.in:34: installing './config.guess'
>configure.in:34: installing './config.sub'
>configure.in:30: installing './install-sh'
>configure.in:30: installing './missing'
>Makefile.am: installing './INSTALL'
>Makefile.am: installing './COPYING' using GNU General Public License v3 file
>Makefile.am:     Consider adding the COPYING file to the version control system
>Makefile.am:     for your code, to avoid questions about which license your >project uses
>gap/Makefile.am: installing './depcomp'
>Symlinking file mkinstalldirs
>Symlinking file po/Makefile.in.in
>
>Please add the files
>  codeset.m4 gettext.m4 glibc21.m4 iconv.m4 isc-posix.m4 lcmessage.m4
>  progtest.m4
>from the /usr/share/aclocal directory to your autoconf macro directory
>or directly to your aclocal.m4 file.
>You will also need config.guess and config.sub, which you can get from
>ftp://ftp.gnu.org/pub/gnu/config/.
>
>checking for a BSD-compatible install... /usr/bin/install -c
>...

These latest two points must be taken in consideration in my opinion,
especially for next rebuildings. You should re-configure locally makefile
instead to use autogen.sh that runs --configure-- command already before
%configure macro during RPM building.   

- %{_datadir}/locale/*/*/*

It is not necessary when you already use "%files -f gimp20-gap.lang"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nuoi3kLKmU&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]