Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956304 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |dominik@xxxxxxxxxxxxxx --- Comment #2 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Initial comments: 0. Is this package EPEL-only? I see chkconfig and service command usage, but no corresponding SystemD commands. 1. Package doesn't build in EPEL-6 x86_64 mock: cd /builddir/build/BUILD/fts-0.0.1/build/src/common && /usr/lib64/ccache/c++ -Dfts_common_EXPORTS -DWITH_IPV6 -DOPENSSL_THREADS -DWITH_OPE NSSL -DNDEBUG -DSOCKET_CLOSE_ON_EXIT -D_REENTRANT -DBOOST_DATE_TIME_HAS_REENTRANT_STD_FUNCTIONS -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 - fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -findirect-inlining -ftree-switch-conversion -ftree-builtin-ca ll-dce -fconserve-stack -Wno-long-long -Wconversion -Wuninitialized -Wno-deprecated-declarations -fno-strict-aliasing -Wextra -Wall -D_FOR TIFY_SOURCE=2 -fstack-protector-all -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O3 -DNDEBUG -fPIC -I/builddir/build/BUILD/fts-0.0.1/build/ src/common -I/builddir/build/BUILD/fts-0.0.1/src/common -I/builddir/build/BUILD/fts-0.0.1/src -I/builddir/build/BUILD/fts-0.0.1/build/src -I /builddir/build/BUILD/fts-0.0.1/src/common/. -o CMakeFiles/fts_common.dir/producer.cpp.o -c /builddir/build/BUILD/fts-0.0.1/src/common/pro ducer.cpp /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp: In function 'void cancelTransfer()': /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:300: error: 'gfal2_cancel' was not declared in this scope /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp: At global scope: /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:484: error: ISO C++ forbids declaration of 'gfalt_event_t' with no type /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:484: error: expected ',' or '...' before 'e' /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp: In function 'void event_logger(int)': /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:489: error: 'e' was not declared in this scope /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:491: error: 'udata' was not declared in this scope /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:502: error: 'GFAL_EVENT_TRANSFER_ENTER' was not declared in this scope /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:505: error: 'GFAL_EVENT_TRANSFER_EXIT' was not declared in this scope /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:510: error: 'GFAL_EVENT_CHECKSUM_ENTER' was not declared in this scope /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:510: error: 'GFAL_EVENT_SOURCE' was not declared in this scope /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:512: error: 'GFAL_EVENT_CHECKSUM_EXIT' was not declared in this scope /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:515: error: 'GFAL_EVENT_DESTINATION' was not declared in this scope /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:520: error: 'GFAL_EVENT_PREPARE_ENTER' was not declared in this scope /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:522: error: 'GFAL_EVENT_PREPARE_EXIT' was not declared in this scope /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:525: error: 'GFAL_EVENT_CLOSE_ENTER' was not declared in this scope /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:527: error: 'GFAL_EVENT_CLOSE_EXIT' was not declared in this scope /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp: At global scope: /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:484: warning: unused parameter 'gfalt_event_t' /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp: In function 'int main(int, char**)': /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:723: error: 'gfalt_set_event_callback' was not declared in this scope /builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:1127: error: 'gfal2_release_file' was not declared in this scope make[2]: *** [src/url-copy/CMakeFiles/fts_url_copy.dir/main.cpp.o] Error 1 and there are missing build dependencies if I try to build on EPEL-5: Error: No Package found for activemq-cpp-library Error: No Package found for libcurl-devel Error: No Package found for pugixml-devel I suggest sorting the BuildRequires and Requires entries alphabetically for easier maintenance. 2. Please explain the need to use these non-standard options for compilation: -findirect-inlining -ftree-switch-conversion -ftree-builtin-call-dce -fconserve-stack -fno-strict-aliasing 3. The descriptions of the (sub)packages are insufficient in detail and should be more verbose. 4. %{python_sitearch}/fts seems to unowned. 5. I see several files in %{_docdir}/fts3. That's not a standard location for documentation. Are these essential to the functioning of the software? Does something break if you remove them? If not, please list them as %doc. 6. only the server subpackage owns files in %{_sbindir}, so you could simply have %{_sbindir}/fts* instead of enumerating every single binary, but that's only a suggestion. Similar situation exists for the man pages. 7. Cosmetic issue: many lines have trailing whitespace. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YCVWwkvbWT&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review