[Bug 841266] Review Request: plink - whole genome association analysis toolset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=841266

--- Comment #13 from Volker Fröhlich <volker27@xxxxxx> ---
You seem to have ignored a few of my previous commments. I'm repeating some of
them here.

Use the %{_mandir} macro.

Why is the binary in /usr/sbin?
http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSBINNONESSENTIALSTANDARDSYSTEMBI

"mkdir -p %{buildroot}%{_mandir}/man1" is enough. You don't need 4 mkdir
invocations.

Why are you not using "make %{?_smp_mflags}"?

Use the version macro in Source0.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bGEit0ETKg&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]