Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: cryptsetup-luks https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225667 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx Flag| |fedora-review?, | |needinfo?(pjones@xxxxxxxxxx) ------- Additional Comments From kevin@xxxxxxxxx 2007-03-06 00:15 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: e134b82b4706a28ba1d73b9176d5ad0c cryptsetup-luks-1.0.3.tar.bz2 e134b82b4706a28ba1d73b9176d5ad0c cryptsetup-luks-1.0.3.tar.bz2.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Headers/static libs in -devel subpackage. OK - Spec has needed ldconfig in post and postun OK - .so files in -devel subpackage. See below - -devel package Requires: %{name} = %{version}-%{release} OK - .la files are removed. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. See below - Should have subpackages require base package with fully versioned depend. OK - Should have dist tag See below - Should package latest version 8 outstanding bugs - check for outstanding bugs on package. Issues: 1. Might have the devel subpackage Requires: %{name} = %{version}-%{release} instead of just Requires: %{name} = %{version} 2. Ditto the docs comments from comment #2. 3. rpmlint says: E: cryptsetup-luks statically-linked-binary /sbin/cryptsetup Needs to be static per the bug mentioned in the changelog. E: cryptsetup-luks zero-length /usr/share/doc/cryptsetup-luks-1.0.3/NEWS E: cryptsetup-luks zero-length /usr/share/doc/cryptsetup-luks-1.0.3/README Should be removed, per issue 2. W: cryptsetup-luks-devel no-documentation Can be ignored. 4. 1.0.4 is out, perhaps upgrade to that? 5. Should the static lib be shipped in the devel package here? Is there anything that uses it? 6. 8 outstanding bugs. Might look at those. I think at least one should be solved by upgrading to 1.0.4, possibly more. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review