Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919260 David Tardon <dtardon@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(manisandro@gmail. | |com) --- Comment #1 from David Tardon <dtardon@xxxxxxxxxx> --- Problems: 1. Both tarball and spec claim that the package's license is GPLv2+, but the code appear to be LGPLv2.1+ . 2. The -devel subpackage should depend on base package of the same arch. I.e., %{name}{%?_isa} = %{version}-%{release} . 3. The -doc subpackage should not depend on base package (at least i suppose you don't need the library to read the documentation). Note that you have to add COPYING to it after removing the dependency. 4. Explicit requires in -devel subpackage are not necessary (except on the base package). rpmbuild will generate them. 5. %defattr is not necessary. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Bhi5QDjSmt&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review