Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917329 --- Comment #3 from Conrad Meyer <konrad@xxxxxxxxxx> --- (In reply to comment #2) > The Source0 is invalid URL, please fix it. How? There is no direct download link from upstream, and RPM does not accept the download URL. > BuildRequires: python-devel is wrong, is python2-devel or python3-devel. Fixed. > Please, can you create a repository for store the package and do a setup.py? I'm sorry, I don't understand what you're asking. What do you want? There is a setup.py in the spec to help it play nice with the Python package system. > %{python_sitelib}/* is wrong too, you must write the name of the package, > example %{python_sitelib}/%{sample}/. Can you point to the relevant packaging guideline for this? Nothing else should be in the build root in %{python_sitelib}. It could be %{python_sitelib}/listquote* if you want. > And the documentation? Have not documentation? No, unfortunately there is no documentation for this package. It is a very simple single-file "library" from upstream. New spec, SRPM: http://konradm.fedorapeople.org/fedora/SPECS/python-listquote.spec http://konradm.fedorapeople.org/fedora/SRPMS/python-listquote-1.4.0-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JVB8NqEkHy&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review