Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924333 --- Comment #13 from Dan Mashal <dan.mashal@xxxxxxxxx> --- (In reply to comment #12) > Both gtk2-devel and dbus-glib-devel are called in configure.ac > But i will change it. Thanks > > 2) gsettings-desktop-schemas-devel > Why? > gsettings-desktop-schemas is an collection package of gsettings schemas for > gnome. > And the -devel subpackage is only needed for applications who needs the > schemas from gsettings-desktop-schemas. > I don't thing that mate-sensor-applet needs gnome gesettings files. > It compiles the gsettings schemas fine without it. > And i don't see this dependency in any debian package from mate upstream. > I know you do this in in a lot of packages. > So pls lighten me up, and explain more detailed why this is needed. You're right, I'll remove that from the rest of the mate packages that don't need it. glib2 provides glib-compile-schemas. > > > 3) (for disabling scrollkeeper) > I use --disable-scrollkeeper and i don't use BR scrollkepper. > And i see no file in /var/scrollkeeper. > IMO, rarian-compat is only needed if a package doesn't compile without > /usr/bin/scrollkeeper-config > which is provide by rarian-compat. > But maybe i'm wrong, pls correct me. " Scrollkeeper In all current Fedora, rarian has replaced scrollkeeper." I know it may compile without it but I add it out of habit because 9/10 it will fail without it. > > 2) Is the nvidia flag required? Is there a way to get the aticonfig bit > > working? > It compiles the nvida part also without using the flag if BR > libXNVCtrl-devel is set, i use it so that everybody can see that the package > is compiled for nvidia usage. > Why is this a MUST not to do this? Sorry, that was not a must just a question. > I can't set the aticonfig bit because for this i need rpmfusion. OK > > Is the sed/libtool command really needed? If so can you submit a pull > > request upstream so that it's not? If not, why? > Yes, this is a valid command for fedora's packages to avoid a rpmlint > warning. > https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib- > dependency OK -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nH0CdCzK48&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review