Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 Robert Kuska <rkuska@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? --- Comment #5 from Robert Kuska <rkuska@xxxxxxxxxx> --- Few things to improve - I found out better SourceURL [1], 0.5.0 is better than master IMO - You are missing upstream docs (README.rst, LICENSE.txt, AUTHORS.txt) in files section - Post and postun section are not needed since there are no txt file to generate tags from for vim-jedi - IMO you should delete Buildroot, Clean and rm -rf $RPM_BUILD_ROOT if you are not packaging for EPEL they are not needed in Fedora (more info [2]) - There is unused command pwd in install section [1] https://github.com/davidhalter/jedi-vim/tarball/0.5.0 [2] https://fedoraproject.org/wiki/How_to_create_an_RPM_package -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RhhZp72cwD&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review