Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=883125 Petr Šabata <psabata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |psabata@xxxxxxxxxx Flags| |fedora-review+ --- Comment #10 from Petr Šabata <psabata@xxxxxxxxxx> --- Alright, I've reviewed the package myself and haven't found any blocking issues either. Approving. Just some notes: Instead of installing the files in the spec, you could work with upstream to produce a better Makefile (e.g. supporting DESTDIR and PREFIX instead of hardcoded paths). Linking against libcrypto should be done there as well. I see upstream is alive so this should be no problem. [cosmetics] %{_mandir}/man?/*.* -- this is a bit overzealous. A single asterisk would have been enough :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6n3ZoKU3kd&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review