[Bug 953859] Review Request: google-noto-fonts - Hinted Open Type fonts for most of the Unicode scripts released by Google

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953859

--- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
sorry for being late.

Review:-
+ Koji scratch build ->
http://koji.fedoraproject.org/koji/taskinfo?taskID=5297420

+ rpmlint gave
google-noto-sans-armenian-fonts.noarch: W: no-documentation
google-noto-sans-devanagari-fonts.noarch: W: no-documentation
google-noto-sans-devanagari-ui-fonts.noarch: W: no-documentation
google-noto-sans-ethiopic-fonts.noarch: W: no-documentation
google-noto-sans-fonts.noarch: W: no-documentation
google-noto-sans-georgian-fonts.noarch: W: spelling-error Summary(en_US) seirf
-> serif, serf
google-noto-sans-georgian-fonts.noarch: W: no-documentation
google-noto-sans-hebrew-fonts.noarch: W: no-documentation
google-noto-sans-khmer-fonts.noarch: W: no-documentation
google-noto-sans-khmer-ui-fonts.noarch: W: no-documentation
google-noto-sans-lao-fonts.noarch: W: no-documentation
google-noto-sans-lao-ui-fonts.noarch: W: no-documentation
google-noto-sans-tamil-fonts.noarch: W: no-documentation
google-noto-sans-tamil-ui-fonts.noarch: W: no-documentation
google-noto-sans-thai-fonts.noarch: W: no-documentation
google-noto-sans-thai-ui-fonts.noarch: W: no-documentation
google-noto-sans-ui-fonts.noarch: W: no-documentation
google-noto-serif-armenian-fonts.noarch: W: no-documentation
google-noto-serif-fonts.noarch: W: no-documentation
google-noto-serif-georgian-fonts.noarch: W: no-documentation
google-noto-serif-lao-fonts.noarch: W: no-documentation
google-noto-serif-thai-fonts.noarch: W: no-documentation
23 packages and 0 specfiles checked; 0 errors, 22 warnings.

+ Source verified with upstream as
http://noto.googlecode.com/svn/trunk/packages/NotoFonts-hinted-2013-04-11.tgz :
  CHECKSUM(SHA256) this package     :
aa7fc867b4d7bf1f07f288d1515bd47d7f2b573877f0fbdf702b3aeac5eeed20
  CHECKSUM(SHA256) upstream package :
aa7fc867b4d7bf1f07f288d1515bd47d7f2b573877f0fbdf702b3aeac5eeed20


Suggestions:
1) -common contains only single file COPYING. Maybe you can drop it and add to
all other subpackages
Requires: fontpackages-filesystem

2) Add dot to end of all summary sentences of all subpackages.

3) Fix the spelling serif in 
google-noto-sans-georgian-fonts.noarch: W: spelling-error Summary(en_US) seirf
-> serif, serf

rest looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TdRISh28FJ&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]