[Bug 924750] Review Request: perl-ExtUtils-ParseXS - Module and a script for converting Perl XS code into C code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=924750

--- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> ---
This is a noarch package, you don't need to define the OPTIMIZE variable.
Line 57 is also unnecessary.

Style nitpicking: capitalize 'requires' on line 37.

Even though META.yml lists ExtUtils::MakeMaker as a runtime dependency, I can't
really tell how it's used.  Similarly, could you explain the perl-devel
dependency?  This package doesn't do any actual C compiling.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5Utj099Zph&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]