Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=952351 Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@xxxxxxxxxxxxxxxxxx --- Comment #3 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> --- Just some quick comments: - There is no license statement needed in the spec file. - 'package_version' and 'package_name' are not really needed. They only duplicate %{name} and {version}. - 'BuildRoot:' and 'rm -rf "%{buildroot}"' are obsolete for latest Fedora and RHEL releases. - '%{?release_suffix}' seems to be a leftover. - The timestamps are not preserved in the %install section. Never seen the use of parallel make in the %install section either. (e.g. make install DESTDIR=%{buildroot} INSTALL="install -p") The package is named 'ovirt-iso-uploader', the binary 'engine-iso-uploader', the manpage 'engine-iso-uploader.8.gz', and the configuration file 'isouploader.conf'. From my point of view a more consistent naming schema would make it easier for user to identify the components which belong together. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=G1dHlC0vQf&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review