Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948359 Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@xxxxxxxxxxxxxxxxxx Summary|Review Request: |Review Request: |python-volatility, a |python-volatility - a |digital artifact extraction |digital artifact extraction |framework |framework --- Comment #1 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> --- Just some quick comments: - Acc. to the package guidelines, the upstream *.egg stuff needs to be removed. https://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries - '%defattr' is obsolete. https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions - %clean is obsolete. https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean - Using macros will make it easier to maintain the package in the future. - 'Group' is obsolete https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag - License is not GPL. It's GPLv2+ (version 2 of the License, or (at your option) any later version.) - The changelog is empty. https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs - rpmlint output is more than you added. As you can see there are a couple of hints about errors in your spec file: [fab@laptop011 reviews]$ rpmlint python-volatility-2.2-1.fc19.src.rpm python-volatility.src: W: spelling-error %description -l en_US visibilty -> visibility, risibility python-volatility.src: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment python-volatility.src: E: no-changelogname-tag python-volatility.src: W: invalid-license GPL python-volatility.src: W: invalid-url Source0: http://volatility.googlecode.com/files/volatility-2.2.tar.gz HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 1 errors, 4 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vmcOuIEJk9&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review