Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891170 --- Comment #2 from Dan Mashal <dan.mashal@xxxxxxxxx> --- (In reply to comment #1) > Hi, > > I believe the pkgconfig requirement should be removed from the -devel > subpackage as per guidelines. > +1 > also this requirement need s changing from > > Requires: %{name} = %{version}-%{release} > > to > > > Requires: %{name}%{?_isa} = %{version}-%{release} > +1 > > In the %install section please change > > %make_install > > > to > > make install DESTDIR=%{buildroot} Not required but desirable. Also please update to 1.7.6. I created a bug asking spot to update ecore to 1.7.6 on rawhide. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4RDg4cbclz&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review