Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951817 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #10 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Since this is (one of) your first reviews, let me also offer some small comments and advice: 1. since Version contains a non-numeric component, consider looking over: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease But, as long as care is taken that subsequent package versions are always considered newer (according to rpm), then all is well. 2. Please document need/purpose of this in %prep: sed -i '1d' gnome_resource/LibreAtlas.desktop That said, I've now sponsored you. Welcome to fedora! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WDjCS9YWG8&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review