[Bug 952579] Review Request: perl-IO-Event - Tied filehandles for nonblocking IO with object callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=952579

--- Comment #2 from Emmanuel Seyman <emmanuel@xxxxxxxxx> ---
(In reply to comment #1)
> Issues
>  - The package doesn't build in mock (caused by missing BRs, see below)

Wow, this sucks.
My apologies for submitting this without checking it built in mock first.

>  - perl(AnyEvent), perl(IO::Socket::INET), and perl(IO::Socket::UNIX) will
> most likely not be autodetected by rpmbuild (not confirmed, see above);
> check that once you build the package and require them explicitly if need be

Done.


> Missing required BRs:
>  - perl(Carp) used in various places
>  - perl(Event::Watcher) used in lib/IO/Event/Event.pm:28
>  - perl(Exporter) used in t/multifork.tt:7
>  - perl(List::MoreUtils) used in lib/IO/Event.pm:1192
>  - perl(Scalar::Util) used in various places
>  - perl(Socket) used in various places

Added.

> Missing recommended BRs:
> (mostly, those modules are part of the perl package *at the moment*; the
> same applies to Test::Simple which you have listed explcitly)
>  - perl - called in spec
>  - perl(AnyEvent::Impl::Perl) - to run various AnyEvent tests properly
>  - perl(diagnostics) used in various places
>  - perl(FindBin) used in various places
>  - perl(IO::Handle) used in lib/IO/Event.pm:133
>  - perl(IO::Pipe) used in t/forked.tt:27
>  - perl(IO::Socket::INET) used in various places
>  - perl(IO::Socket::UNIX) used in lib/IO/Event.pm:1290
>  - perl(POSIX) used in various places
>  - perl(strict) used in various places
>  - perl(Symbol) used in lib/IO/Event.pm:131
>  - perl(Sys::Hostname) used in various places
>  - perl(Test::More) used in various places
>  - perl(Time::HiRes) used in various places
>  - perl(warnings) used in various places

Added too.

> Tips:
>  - PERL_INSTALL_ROOT could be substituted with common DESTDIR

Done.

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-IO-Event/perl-IO-Event.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-IO-Event/perl-IO-Event-0.809-2.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AxOxvHPfSz&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]