Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #1 from Michael Schwendt <mschwendt@xxxxxxxxx> --- * rpmlint only finds a few incorrect-fsf-address issues: https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address Reported: https://sourceforge.net/tracker/?group_id=257241&atid=1551608 * sidplayfp options --none and --nosid segfault. Reported: https://sourceforge.net/tracker/?func=detail&aid=3611237&group_id=257241&atid=1551608 * stilview usage txt refers to USAGE.txt file that isn't packaged. Reported: https://sourceforge.net/tracker/?group_id=257241&atid=1551608 Run-time test: $ HVSC_BASE=/home/ms19a/Music/INCOMING/HVSC/C64Music stilview -e=/DEMOS/0-9/3_Oversample.sid TITLE: Get Ready ARTIST: Jeroen Tel COMMENT: Same as /MUSICIANS/T/Tel_Jeroen/HCS_etc/Get_Ready.sid, but with digis added and with voice 1 largely muted. * Build with pulseaudio and ALSA? $ grep alsa sidplayfp.spec BuildRequires: libsidplayfp-devel alsa-lib-devel pulseaudio-libs-devel $ rpm -qR sidplayfp|grep alsa $ Somebody has reported it already: https://sourceforge.net/tracker/?func=detail&aid=3609103&group_id=257241&atid=1551608 * Run-time test: It's expected that with no ROM images available, some sids that did play with libsidplay1 are just silent (since old libsidplay set up fake interrupts, e.g. CIA Timer IRQs, for non VBI-speed playback). Installing the non-free "vice-data" package makes those test tunes work. Since a few users have asked about such silent sids before in upstream tracker, I will contact upstream about whether it is known how much exactly is missing (e.g. just default IRQ handlers in kernal space or larger parts?). * Untested: The "Songlength Database" which is also touched by one of the patches. I dunno what may have changed over the past years, whether it works and whether it is still updated. > make install DESTDIR=$RPM_BUILD_ROOT Just for the record, nowadays there's %make_install for that. * Other than that, I see no packaging mistakes. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HpTOEyLUdp&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review