Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951817 --- Comment #8 from Micah Roth <micah.roth@xxxxxxxx> --- https://bugzilla.redhat.com/show_bug.cgi?id=952632 I started this informal review. I am looking for other "low hanging fruit" to look at, I am very happy to hear your suggestions, here or on IRC or email or whatever. wrt $RPM_BUILD_ROOT, (http://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS) seems to indicate that is is exactly the same - should we ask the FPC to update the guidelines to indicate that $RPM_BUILD_ROOT is deprecated? wrt $make_install, (http://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used) indicates that $makeinstall should NOT be used but that $make_install is the exact same as "make DESTDIR=$RPM_BUILD_ROOT install". Again, should we ask the FPC to update the guidelines? Thank you, ~Micah -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4vWSVnF8YD&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review